-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System-Probe] remove code duplication in modules config pkgs #30259
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46914426 --os-family=ubuntu Note: This applies to commit b7df31b |
…robe modules and replaced them with FullKeyPath
054e15a
to
fe92759
Compare
Regression DetectorRegression Detector ResultsRun ID: 6f582883-05ab-42a9-ae7f-2354908019c7 Metrics dashboard Target profiles Baseline: 7583542 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.02 | [+0.29, +1.75] | 1 | Logs |
➖ | file_tree | memory utilization | +0.62 | [+0.50, +0.75] | 1 | Logs |
➖ | idle | memory utilization | +0.62 | [+0.56, +0.67] | 1 | Logs bounds checks dashboard |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.21 | [+0.15, +0.26] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.09, +0.09] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.49, +0.48] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.35, +0.30] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.22, +0.13] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.29, +0.19] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -0.06 | [-2.87, +2.76] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.32 | [-0.55, -0.09] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.84 | [-1.64, -0.03] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.29 | [-3.78, +1.20] | 1 | Logs |
➖ | idle_all_features | memory utilization | -1.42 | [-1.56, -1.29] | 1 | Logs bounds checks dashboard |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
❌ | idle | memory_usage | 9/10 |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Switched to use systemprobe/config.FullKeyPath to construct a full key path in the config from different fragments
Motivation
remove code duplication
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes